Testing Review
A review skill for test code quality, structure, and coverage strategy.
What it covers
- Test isolation — no shared mutable state between tests, proper setup/teardown, deterministic ordering
- Assertion quality — specific assertions over toBeTruthy, testing behavior not implementation, snapshot discipline
- Test structure — arrange/act/assert pattern, descriptive test names, avoiding logic in tests
- Factory patterns — test data builders, avoiding hardcoded fixtures, minimal data for each test case
- Coverage strategy — critical path coverage, edge cases, error paths, not chasing percentage metrics
- E2E discipline — page object patterns, stable selectors, retry-aware assertions
When to use
Run this on any PR that adds or modifies tests. Especially valuable during test suite refactors or when test flakiness becomes a recurring problem.